Fix empty md("") in Quarto#1772
Merged
rich-iannone merged 3 commits intorstudio:masterfrom Jul 12, 2024
Merged
Conversation
Make sure no "" are sent to `charToRaw()`. rstudio#1769
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Basically, the underlying problem was that
charToRaw("")givescharacter(0).I therefore replaced the condition
!is.na(x)bynzchar(x, keepNA = FALSE)(a more elegent!is.na(x) & x != "")I added a mocking mechanism to allow for testing in Quarto functions. I think it is worth adding to it.
For more on mocking, see https://www.tidyverse.org/blog/2023/10/testthat-3-2-0/#mocking.
I could have set a temp env var with
withr::local_envvar(), but thought it read more clearly this way.I tested my test and it indeed fails with current main!
Related GitHub Issues and PRs
Fixes #1769, amends #1690
Checklist
testthatunit tests totests/testthatfor any new functionality.