Correctly output vec_fmt_markdown() inside Quarto#1841
Merged
rich-iannone merged 1 commit intorstudio:masterfrom Aug 19, 2024
Merged
Correctly output vec_fmt_markdown() inside Quarto#1841rich-iannone merged 1 commit intorstudio:masterfrom
vec_fmt_markdown() inside Quarto#1841rich-iannone merged 1 commit intorstudio:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1840
Basically, the idea is that since
vec_fmt_markdown()callsfmt_markdown()(and not the other way around, we can use some code to trickvec_fmt_markdown()to think it is not inside Quarto.I tried using
on.exit(Sys.unsetenv("QUARTO_BIN_PATH")but it didn't work for some reason. Would love to not use withr here.I know tidyselect imports it, so gt has an indirect dep on it, but since withr 3.0 has simplified its code, it is possible they remove that dep at some point.