Skip to content

Spanner div instead of span to fix spanner rendering in Quarto#1856

Merged
rich-iannone merged 3 commits intorstudio:masterfrom
olivroy:spanner-div
Aug 23, 2024
Merged

Spanner div instead of span to fix spanner rendering in Quarto#1856
rich-iannone merged 3 commits intorstudio:masterfrom
olivroy:spanner-div

Conversation

@olivroy
Copy link
Copy Markdown
Collaborator

@olivroy olivroy commented Aug 22, 2024

Summary

from #1842 (comment)

Change <span> into <div>

The footnote issue (#1773) will need a fix similar to #1013 but readjust with new regexps. #1855 aims to make that future fix more obvious!

Related GitHub Issues and PRs

Fixes #1839

Checklist

@olivroy olivroy requested a review from rich-iannone August 22, 2024 22:38
Copy link
Copy Markdown
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rich-iannone
Copy link
Copy Markdown
Member

Thank you!

@rich-iannone rich-iannone merged commit ab34e7e into rstudio:master Aug 23, 2024
@olivroy olivroy deleted the spanner-div branch August 23, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spanners appear incorrect when rendering with Quarto

2 participants