Misc performance improvements for nanoplots / vec_*() functions.#1888
Merged
rich-iannone merged 1 commit intorstudio:masterfrom Sep 25, 2024
Merged
Misc performance improvements for nanoplots / vec_*() functions.#1888rich-iannone merged 1 commit intorstudio:masterfrom
vec_*() functions.#1888rich-iannone merged 1 commit intorstudio:masterfrom
Conversation
This was referenced Sep 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve a little performance for
vec_*()by avoiding converting to a tibble and remove some dplyr calls togroup_vars().This could probably be improved further, but saw these quick fixes so I added that.
Checklist
testthatunit tests totests/testthatfor any new functionality.I wonder if this could be improved further. I used the first example of
cols_nanoplot()Before
This PR:

~8% gain! Not that bad I guess?