Enhance the extract_body() function by adding inclusion options#1889
Merged
Conversation
Collaborator
|
I agree with the changes! Maybe it would be worth adding Since this is technically a breaking change, it is worth adding to news. gt_tbl <- gt(exibble)
# before this PR, this would work.
extract_body(gt_tbl, "unfmt_included", "html") |
olivroy
approved these changes
Sep 25, 2024
Co-authored-by: olivroy <52606734+olivroy@users.noreply.github.com>
Co-authored-by: olivroy <52606734+olivroy@users.noreply.github.com>
Co-authored-by: olivroy <52606734+olivroy@users.noreply.github.com>
Member
Author
|
Thanks for the review! I'll add a note to NEWS describing the breaking changes here. Also, before finishing this up, I'll add 1-2 examples since there aren't any right now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update of the
extract_body()function includes two new arguments:incl_hidden_colsandincl_stub_cols. Previously, the function always returned a data frame that contained hidden columns. And, though stub columns were included, there was no way to exclude them from the returned data frame.Fixes: #1875