Improve performance by having boxhead as a data frame.#1896
Merged
rich-iannone merged 6 commits intorstudio:masterfrom Oct 1, 2024
Merged
Improve performance by having boxhead as a data frame.#1896rich-iannone merged 6 commits intorstudio:masterfrom
rich-iannone merged 6 commits intorstudio:masterfrom
Conversation
Collaborator
Author
|
The snapshot failure was due to the new katex package I didn't yet have installed. To prevent this issue from happening in the future, I am stripping the katex version from the snapshot. I verified manually that only the katex version changed in the snapshot! The rest is the same |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It proved more challenging than I thought initially, because of the way R nests objects in data frame vs how tibble does it.
I added a workaround to unnest such objects to improve performance
Related GitHub Issues and PRs
See how the boxhead initalialization takes a full 2 seconds
This PR:
I have added a few (simpler) tests to make sure this doesn't break (or is easier to debug)
The only remaining thing would be to find a way to avoid resolving columns as this alone takes up a full second of run time. I will think of this.
Checklist
testthatunit tests totests/testthatfor any new functionality.