Autocoloroptions

[xx02al]

I have added light and dark autocolor_text color options. Often, tables are embedded in a context and in there "black" is not black, but another very dark color and analogously for white. Being able to design the tables in harmony is central.

The current implementation follows the previous design of {gt}, particularly data_color(), but/thus it is unattractive in that if autocolor = FALSE, now allready 3 arguments are irrelevant.

• [ x] I understand and agree to the Code of Conduct.
• I have listed any major changes in the NEWS.
• [x ] I have added testthat unit tests to tests/testthat for any new functionality.

Additionally, I fixed a constant in the calculation of relative luminance WCAG (according to documentation).

[CLAassistant]

All committers have signed the CLA.

[xx02al]

Hi @rich-iannone and @olivroy since it has been a while since I opened this pull request, and I would still like to be able to use this feature in various situations (i.e., tables I create), I would like to ask what you think about it!?

[olivroy]

Overall, good start! Sorry for the delay.

I think this is a good idea. Can't garantee that we merge it. I'd suggest adding some before / after (visual) examples of the improvement this PR brings.

We'd like to avoid new imports, so if you find a way to accomplish this without using farver, it would be great.

It is good that you added some tests.

Also, feel free to use gt from your PR `pak::pak("#1930") and report back if you see that something that is off.

You would need to add a news bullet as well that briefly describe the change https://style.tidyverse.org/news.html

[olivroy]

Could you add this in Suggrsts instead? We cannot add another import due to CRAN restrictions

[xx02al]

Understand. Using {farver} to offer the user the possibility to specify the color in a range of different specifications (literally everything that {farver} can handle), as well as {farver} has the task and responsibility to convert precisely (remember also base R limitations) into the desired #RRGGBB hexadecimal format.
I have added it to “Suggests”, as has been done with other pkgs elsewhere in gt with packages that are only used in a very specific case. I think that is reasonable.

[olivroy]

Please follow the pattern above and give a short description

For example, #' @param autocolor_light *Automatic light color*

[xx02al]

done

[olivroy]

Same

[xx02al]

done

[olivroy]

Why is this necessary?
We don't use this pattern of encoding / decoding colors in the package..

[xx02al]

See just above.

[xx02al]

Here's an example, not because it is particularly aesthetically pleasing, but I think it serves the purpose of clearly pointing out differences. Run it with and without autocolor_light = "#FFE8D1".

exibble |>
  gt() |> 
  data_color(
    columns = c(fctr, datetime, group),
    method = "factor",
    rows = c(2, 4:6, 8),
    palette = "#725F0B",
    na_color = "#B6D7C7",
    autocolor_light = "#FFE8D1"
  ) |> 
  data_color(
    columns = c(date, currency),
    palette = "#6E6684",
    na_color = "#B6D7C7",
    autocolor_light = "#FFE8D1"
  ) |> 
  tab_options(
    table.background.color = "#004249",
    table.font.color.light = "#FFE8D1"
  )

[rich-iannone]

LGTM!