Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd `dt_*()` methods for all major, internal data structures #355
Conversation
* master: Fix for invisible top borders in rendered HTML tables (#359)
|
This is known to break rtf output, but given the major improvements, that is ok. Add an issue to fix rtf once merged. |
|
I didn't actually review this, consider this a resurrection of @schloerke's Approval. |
rich-iannone
merged commit 48f2d73
into
master
3 of 5 checks passed
3 of 5 checks passed
Closed
rich-iannone
added a commit
to batpigandme/gt
that referenced
this pull request
Nov 11, 2019
* master: (59 commits) add fmt_markdown to _pkgdown.yml (rstudio#371) Use `tidy_grepl()` instead of `expect_match()` Use `tidy_grepl()` & `expect_true()` Add `dt_*()` methods for all major, internal data structures (rstudio#355) Update CLA text (rstudio#373) remove reliance on Github version of sass, which is now updated on CRAN (rstudio#366) Fix for invisible top borders in rendered HTML tables (rstudio#359) CSS modifications (rstudio#346) Incorporate alpha option to `cell_fill()` (rstudio#340) Enable option to set row group padding in `tab_options()` (rstudio#342) Modify `filter()` statement (rstudio#341) Allow use of integers in `pct()`/`px()` (rstudio#336) Fix for resolving row group cells (rstudio#335) Easier access to footnote mark options (rstudio#333) Export `as.tags.gt_tbl()` (rstudio#331) Several `rlang`-based fixes (rstudio#334) Add function to specify column widths: `cols_widths()` (rstudio#293) Add `rstudio/sass` to Remotes list (rstudio#326) Fix for `cell_borders()` (rstudio#323) Allow an empty table with zero rows to create an empty gt table (rstudio#283) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This PR provides a suite of functions (e.g.,
dt_boxh_*(),dt_spanners_*(), etc.) for initializing, setting (as attrs), and modifying internal objects.Fixes: #381
Fixes: #367
Fixes: #360
Fixes: #356
Fixes: #317
Fixes: #298
Fixes: #266
Fixes: #264
Fixes: #242
Fixes: #228
Fixes: #214
Fixes: #99
Fixes: #23