Skip to content

Conversation

@hadley
Copy link
Member

@hadley hadley commented May 7, 2020

You accidentally depended on a scales 1.1.0 bug (and in general, it's a bad idea to test errors generated by other packages).

Is there any chance you could do a quick gt release with this fix so I can submit scales to CRAN in the near future?

@hadley hadley mentioned this pull request May 7, 2020
16 tasks
@rich-iannone rich-iannone requested a review from jcheng5 May 7, 2020 22:08
@rich-iannone
Copy link
Member

Thanks! Me and Joe will definitely review this during our next meeting. We have made a number of fixes for the next release of gt, so, this is great timing (and this fix will be included). However, the release probably won't happen until mid- to late-June because we have a very large backlog of PRs that have to go through our QA process (and that likely won't happen for a few weeks because there is Shiny testing happening first).

@hadley
Copy link
Member Author

hadley commented May 7, 2020

I have to submit scales to CRAN with a deadline of May 12. If you're ok with gt failing on CRAN for a bit (it's only a broken unit test not a behaviour change), I can just go ahead and submit and say that you have a fix inflight.

@jcheng5
Copy link
Member

jcheng5 commented May 7, 2020

If CRAN seriously objects we can also do a patch release with just this change, QA has signed off on things like that before.

@jcheng5 jcheng5 merged commit b2ee76b into master May 13, 2020
@jcheng5 jcheng5 deleted the scales-1.1.1 branch May 13, 2020 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants