Skip to content

Speed up rendering #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rich-iannone merged 12 commits into from
Nov 2, 2020
Merged

Speed up rendering #664

rich-iannone merged 12 commits into from
Nov 2, 2020

Conversation

@jcheng5
Copy link
Member

@jcheng5 jcheng5 commented Oct 19, 2020 •
edited
Loading 

profvis::profvis(print(gt::gt(gt::pizzaplace[1:1000,])))

@jcheng5
Sketching out some performance increases
368353c 
TODO: Harden the sprintf that creates body <td>
@jcheng5 jcheng5 added this to the v0.2.2 milestone Oct 19, 2020
@rich-iannone rich-iannone modified the milestones: v0.2.2, v0.2.3 Oct 27, 2020
@jcheng5 jcheng5 changed the title Sketching out some performance increases Speed up rendering Nov 2, 2020
jcheng5
jcheng5 commented Nov 2, 2020
View reviewed changes
@jcheng5 jcheng5 marked this pull request as ready for review November 2, 2020 19:47
@jcheng5 jcheng5 requested a review from rich-iannone November 2, 2020 19:48
rich-iannone
rich-iannone approved these changes Nov 2, 2020
View reviewed changes
Copy link
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rich-iannone rich-iannone merged commit f11e0a5 into master Nov 2, 2020
@rich-iannone rich-iannone deleted the perf-2020-10 branch November 2, 2020 20:20
rich-iannone added a commit that referenced this pull request Nov 2, 2020
@rich-iannone
Merge branch 'master' into spanner-id
b79fd10 
* master:
  Speed up rendering (#664)
  Link to documentation site (#669)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rich-iannone rich-iannone rich-iannone approved these changes

Assignees

@rich-iannone rich-iannone

Labels

None yet

Projects

None yet

Milestone

v0.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jcheng5 @rich-iannone