Add spanner id as an argument to tab_spanner()#665
Merged
rich-iannone merged 36 commits intomasterfrom Nov 9, 2020
Merged
Conversation
If `column_names` evals to NULL or an empty vector, return `data` unchanged
Member
|
After discussing in person:
|
jcheng5
reviewed
Oct 28, 2020
jcheng5
reviewed
Oct 28, 2020
jcheng5
reviewed
Oct 28, 2020
jcheng5
reviewed
Oct 28, 2020
jcheng5
suggested changes
Oct 28, 2020
Member
jcheng5
left a comment
There was a problem hiding this comment.
Just the nits from the comments
tab_spanner()id as an argument to tab_spanner()
jcheng5
suggested changes
Oct 30, 2020
Member
jcheng5
left a comment
There was a problem hiding this comment.
- RTF needs to use spanner id's instead of labels.
- rle() needs to use
spanner_idinstead ofspanner. - Test case with adjacent spanners that use same label but different IDs; they should not be merged into one spanner.
Member
Author
All of these items are addressed now and I took the time to fine tune the docs for |
jcheng5
reviewed
Nov 4, 2020
jcheng5
reviewed
Nov 4, 2020
jcheng5
suggested changes
Nov 4, 2020
Member
jcheng5
left a comment
There was a problem hiding this comment.
- Test cases with spanner id != spanner label, for HTML, latex and rtf
- More test cases for latex and rtf
* master: pkgdown updates (#676)
jcheng5
approved these changes
Nov 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows for the setting of a spanner ID value, which makes it easier to access a spanner column label through
cells_column_spanners()(when usingtab_style()ortab_footnote()]), it occurs through theidvalue (and not thelabel). If anid` is not provided here, it will be generated from the label, stripping any tags and special characters, and limiting the generated string to 10 characters.Although a message will be provided in this case, it is advised that an explicit
idvalue be set if planning to access this cell in a later function call. Also, when providing anid, it must be unique across all ID values set for column spanner labels.Fixes: #521
Fixes: #626
Fixes: #597