Skip to content

Convert columns to tidyselect semantics #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rich-iannone merged 63 commits into from
Mar 17, 2021
Merged

Convert columns to tidyselect semantics #718

rich-iannone merged 63 commits into from
Mar 17, 2021

Conversation

@jcheng5
Copy link
Member

@jcheng5 jcheng5 commented Feb 26, 2021 •
edited
Loading

  • Revisit version number in translate_legacy_resolve_expr deprecation messages once we know what version we'll actually ship this
  • Implement resolve_rows_l/resolve_rows_i
  • Convert all existing code to use new resolution functions
  • Fix gt(exibble) %>% summary_rows(columns = num, fns = list(mean = ~mean(.)))

jcheng5
jcheng5 commented Mar 3, 2021
View reviewed changes
jcheng5
jcheng5 commented Mar 3, 2021
View reviewed changes
jcheng5
jcheng5 commented Mar 3, 2021
View reviewed changes
jcheng5 and others added 20 commits March 3, 2021 10:50
@jcheng5
Refactor to introduce variable (again)
24e7ec2
@rich-iannone
Add several testthat tests
07b819e
@rich-iannone
Use new resolver fns in resolve_cells_body()
c32948e
@rich-iannone
Update test-tab_footnote.R
298d8e5
@rich-iannone
Optionally exclude non-body cols in resolve_cols_i()
0debc13
@rich-iannone
Rewrite table code to avoid deprecated values
34709c9
@rich-iannone
Update several testthat tests
39f93f0
@rich-iannone
Update the resolve_cells_stub() fn
7d7febe
@rich-iannone
Update test-location_cells.R
a59779a
@rich-iannone
Update args for cells_body()
785ef45
@rich-iannone
Remove cell_data() (deprecated fn)
d3afb59
@rich-iannone
Add default everything() val to fn
9c74661
@rich-iannone
Update help files using roxygen
c5a56c1
@rich-iannone
Update NAMESPACE
665ec70
@rich-iannone
Update internal resolution of column labels
8afdf7d
@rich-iannone
Update several testthat tests
1071478
@rich-iannone
Update resolve_cols_c() to include body_only
2fb6bf8
@rich-iannone
Update resolve_location.*() methods
9f1eec5
@rich-iannone
Update cells_body() call
dbb84d8
@rich-iannone
Update several testthat tests
db82d5f
jcheng5
jcheng5 commented Mar 15, 2021
View reviewed changes
jcheng5
jcheng5 commented Mar 15, 2021
View reviewed changes
jcheng5
jcheng5 commented Mar 15, 2021
View reviewed changes
@rich-iannone rich-iannone self-requested a review March 15, 2021 20:38
jcheng5
jcheng5 commented Mar 17, 2021
View reviewed changes
jcheng5
jcheng5 commented Mar 17, 2021
View reviewed changes
rich-iannone
rich-iannone approved these changes Mar 17, 2021
View reviewed changes
Copy link
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great now.

@rich-iannone rich-iannone merged commit 14e5d04 into master Mar 17, 2021
@rich-iannone rich-iannone deleted the tidyselect branch March 17, 2021 18:59
@rich-iannone rich-iannone mentioned this pull request Mar 17, 2021
Closed
rich-iannone added a commit that referenced this pull request Mar 18, 2021
@rich-iannone
Merge branch 'master' into unhide-columns
a692db0 
* master:
  Convert columns to tidyselect semantics (#718)
  update the test
  remove # escaping for bookdown label
  fixed typo in modify_columns.R documentation
  Use `group_by()` instead of `group_by_at()`
  Use `group_by_at()` to maintain set logic
  Avoid using deprecated .dots arg in `group_by()`
rich-iannone added a commit that referenced this pull request Mar 22, 2021
@rich-iannone
Merge branch 'master' into row-group-id
aa4f139 
* master: (26 commits)
  Remove irrelevant tests
  Update README
  Update license year info
  Update testthat tests
  Update _pkgdown.yml
  Update `cols_unhide()` to new tidyselect API
  Update test-table_parts.R
  Update PNG images for examples
  Update cols_unhide.Rd
  Update doc examples for `cols_unhide()`
  Update documentation with roxygen
  Add to NAMESPACE
  Add `dt_boxhead_set_not_hidden()` util fcn
  Modify internal documentation
  Add the `cols_unhide()` function
  Update intro-creating-gt-tables.Rmd
  Update gt-datasets.Rmd
  Update creating-summary-lines.Rmd
  Update case-study-gtcars.Rmd
  Convert columns to tidyselect semantics (#718)
  ...
@rich-iannone rich-iannone mentioned this pull request Apr 27, 2021
Closed
@rich-iannone rich-iannone linked an issue Apr 27, 2021 that may be closed by this pull request
Use of minus sign in vars() causes error #261
Closed
@rich-iannone rich-iannone mentioned this pull request Apr 27, 2021
Closed
@rich-iannone rich-iannone linked an issue Apr 28, 2021 that may be closed by this pull request
fmt_number with columns = vars(where(is.numeric)) gives an error #618
Closed
@rich-iannone rich-iannone mentioned this pull request Apr 28, 2021
Closed
@rich-iannone rich-iannone linked an issue Apr 28, 2021 that may be closed by this pull request
There should be an easy way to use fmt_number on all numeric columns #613
Closed
@rich-iannone rich-iannone mentioned this pull request Apr 28, 2021
Closed
@rich-iannone rich-iannone linked an issue Apr 28, 2021 that may be closed by this pull request
select negate/except/exclude columns #624
Closed
@rich-iannone rich-iannone mentioned this pull request Apr 28, 2021
Closed
@nmarantz nmarantz mentioned this pull request Sep 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rich-iannone rich-iannone rich-iannone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

3 participants

@jcheng5 @rich-iannone