Refactor and improve rendering of title/subtitle components in HTML/LaTeX tables #779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcheng5
reviewed
Jun 4, 2021
jcheng5
reviewed
Jun 4, 2021
jcheng5
reviewed
Jun 4, 2021
jcheng5
reviewed
Jun 4, 2021
jcheng5
reviewed
Jun 4, 2021
jcheng5
reviewed
Jun 4, 2021
jcheng5
reviewed
Jun 7, 2021
jcheng5
approved these changes
Jun 7, 2021
rich-iannone
added a commit
that referenced
this pull request
Jun 11, 2021
* master: (24 commits) Fix for possible column name duplication when generating summary rows (#792) Change the `data` arg to `.data` to avoid partial matching issues (#772) Add the `force_sign` arg to several numeric formatters (#793) Add the `fmt_engineering()` and `fmt_integer()` formatter functions (#758) HTML summary row styling fix (#782) Refactor and improve rendering of title/subtitle components in HTML/LaTeX tables (#779) LaTeX bugfix for summary rows, and, implementation of grand summary rows (#768) Reinstate once failing test Include stub var in resolution of visible vars Use `seq_len()` instead of `seq()` Fix typo in README (#765) Increment version number (#762) Increase version number Documentation fixes (#759) Add missing topics to _pkgdown.yml Add `accounting` options for `fmt_percent()` and `fmt_number()` (#756) Simplify arguments for RTF page numbering Add the `fmt_bytes()` formatter function (#750) Simplify page numbering text Add testthat snapshot tests for RTF page numbering ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would seem that the underlying bug that resulted in a LaTeX building error (when
subtitlewasNULLwhen callingtab_header()) has been solved (initial testing here confirms it's not a problem inv0.3.0). However, this PR is an opportunity to refactor the HTML and LaTeX rendering functions for the header component.This guards against a LaTeX error that can occur if an empty string or a string entirely composed of spaces is provided in
subtitle. The low-leveldt_heading_has_subtitle()function has extra checks for these types of inputs. This also fixes HTML rendering when there's no subtitle since HTML markup with an empty string would be generated, resulting in extra vertical space upon rendering.Several testthat snapshot tests were added.
Fixes: #463
Fixes: #623