Bug fixes and enhancements to date/time formatters #801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcheng5
reviewed
Jun 15, 2021
jcheng5
reviewed
Jun 15, 2021
jcheng5
reviewed
Jun 15, 2021
jcheng5
reviewed
Jun 15, 2021
* master: Add padding options for heading and column labels (#795)
jcheng5
reviewed
Jun 22, 2021
jcheng5
reviewed
Jun 22, 2021
jcheng5
reviewed
Jun 22, 2021
krlmlr
reviewed
Jan 12, 2022
Contributor
krlmlr
left a comment
krlmlr
left a comment
There was a problem hiding this comment.
I had a very quick look. My biggest question here is: why does gt need to be concerned with parsing date/time/datetime values from strings? How bad would it be if gt accepted only properly typed data? Perhaps we could support two code paths, one for character input (legacy, using existing code) and one for typed input (without support for parsing)?
| date_style %in% as.character(date_format_num_range) | ||
| ) { | ||
| date_style <- as.numeric(date_style) | ||
| } |
Contributor
There was a problem hiding this comment.
Nitpick: An else if here and below makes the purpose of these three blocks a bit clearer.
Suggested change
| } | |
| } else if ... |
| call. = FALSE | ||
| ) | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| } | |
| } else if ... |
| time_style %in% as.character(time_format_num_range) | ||
| ) { | ||
| time_style <- as.numeric(time_style) | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| } | |
| } else if ... |
| call. = FALSE | ||
| ) | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| } | |
| } else if ... |
R/utils.R
Outdated
|
|
||
| has_dt_tz <- function(x) { | ||
|
|
||
| grepl(".+(Z|z|(\\+|-)[0-9]{2}([:]?[0-9]{2})?)?$", "2020-04-21T13:04:58.321Z") |
Contributor
There was a problem hiding this comment.
Is this used?
Suggested change
| grepl(".+(Z|z|(\\+|-)[0-9]{2}([:]?[0-9]{2})?)?$", "2020-04-21T13:04:58.321Z") | |
| grepl(".+(Z|z|(\\+|-)[0-9]{2}([:]?[0-9]{2})?)?$", x) |
Member
Author
There was a problem hiding this comment.
Now corrected. Currently it isn't used (should be removed before merging if never used).
* master: Fixes to footer (footnotes and source notes) across all output formats (#864) Row group labels as a column in stub (#855) Use reusable GHA workflows (#847) Increment version number v0.3.1 Release Candidate (#821) Fix for styles applied to summary cells when row groups are reordered (#814) Update image generation functions (#803) `cell_text()` fix (#805) Add whitespace options for text (#797)
…o date-time-fmt-fix
jcheng5
reviewed
Jan 25, 2022
jcheng5
reviewed
Jan 25, 2022
jcheng5
reviewed
Jan 25, 2022
jcheng5
reviewed
Jan 25, 2022
jcheng5
reviewed
Jan 25, 2022
jcheng5
reviewed
Jan 25, 2022
jcheng5
approved these changes
Jan 28, 2022
rich-iannone
added a commit
that referenced
this pull request
Jan 28, 2022
* master: Bug fixes and enhancements to date/time formatters (#801)
rich-iannone
added a commit
that referenced
this pull request
Feb 1, 2022
* master: Add ability to set global locale in `gt()` (#866) Bug fixes and enhancements to date/time formatters (#801) Fixes to footer (footnotes and source notes) across all output formats (#864) Row group labels as a column in stub (#855) Use reusable GHA workflows (#847) Increment version number v0.3.1 Release Candidate (#821)
rich-iannone
added a commit
that referenced
this pull request
Feb 2, 2022
* master: (23 commits) Improve color handling and add tests (#870) Change HTML percent sign to literal `%` (#871) Add ability to set global locale in `gt()` (#866) Bug fixes and enhancements to date/time formatters (#801) Update gt_workflow_diagram.svg Update gt_parts_of_a_table.svg Update README.md Add dedicated ISSUE TEMPLATEs Update README.md Delete README.Rmd Update intro-creating-gt-tables.Rmd Update LICENSE Make corrections to docs (`columns`/`rows`) Update _pkgdown.yml Fixes to footer (footnotes and source notes) across all output formats (#864) Row group labels as a column in stub (#855) Use reusable GHA workflows (#847) Increment version number v0.3.1 Release Candidate (#821) Fix for styles applied to summary cells when row groups are reordered (#814) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a bugfix, more flexibility, improved documentation, and more testing for the date/time formatting functions (
fmt_date(),fmt_time(), andfmt_datetime()). NowDateandPOSIXctcolumns are allowed to be formatted with these functions.Fixes: #775
Fixes: #800
Fixes: #612