Fix for styles applied to summary cells when row groups are reordered #814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcheng5
approved these changes
Jul 9, 2021
rich-iannone
added a commit
that referenced
this pull request
Jan 24, 2022
* master: Fixes to footer (footnotes and source notes) across all output formats (#864) Row group labels as a column in stub (#855) Use reusable GHA workflows (#847) Increment version number v0.3.1 Release Candidate (#821) Fix for styles applied to summary cells when row groups are reordered (#814) Update image generation functions (#803) `cell_text()` fix (#805) Add whitespace options for text (#797)
rich-iannone
added a commit
that referenced
this pull request
Feb 2, 2022
* master: (23 commits) Improve color handling and add tests (#870) Change HTML percent sign to literal `%` (#871) Add ability to set global locale in `gt()` (#866) Bug fixes and enhancements to date/time formatters (#801) Update gt_workflow_diagram.svg Update gt_parts_of_a_table.svg Update README.md Add dedicated ISSUE TEMPLATEs Update README.md Delete README.Rmd Update intro-creating-gt-tables.Rmd Update LICENSE Make corrections to docs (`columns`/`rows`) Update _pkgdown.yml Fixes to footer (footnotes and source notes) across all output formats (#864) Row group labels as a column in stub (#855) Use reusable GHA workflows (#847) Increment version number v0.3.1 Release Candidate (#821) Fix for styles applied to summary cells when row groups are reordered (#814) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #812, it was reported that using
tab_style()withcells_summary()as a location and usingrow_group_order()(to reorder row groups) results in missing the style (or unformatted).The issue was the internal
reorder_styles()function. It's purpose is to updaterownumvalues in the internalstylestable to the finalized row order. However,rownumvalues for summary and grand rows should never be altered sincerownumfor those locations means the order of summary rows for each grouping (always starting from1).Fixes: #812