Improve color handling and add tests #870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcheng5
suggested changes
Feb 1, 2022
Member
jcheng5
left a comment
jcheng5
left a comment
There was a problem hiding this comment.
- Use regex to implement short-to-long hex color conversion
- Find out what happens if "transparent" is used with latex/rtf
* master: Change HTML percent sign to literal `%` (#871) Update gt_workflow_diagram.svg Update gt_parts_of_a_table.svg Update README.md Add dedicated ISSUE TEMPLATEs Update README.md Delete README.Rmd Update intro-creating-gt-tables.Rmd Update LICENSE Make corrections to docs (`columns`/`rows`) Update _pkgdown.yml
jcheng5
approved these changes
Feb 2, 2022
rich-iannone
added a commit
that referenced
this pull request
Feb 2, 2022
* master: Improve color handling and add tests (#870)
rich-iannone
added a commit
that referenced
this pull request
Feb 2, 2022
* master: (23 commits) Improve color handling and add tests (#870) Change HTML percent sign to literal `%` (#871) Add ability to set global locale in `gt()` (#866) Bug fixes and enhancements to date/time formatters (#801) Update gt_workflow_diagram.svg Update gt_parts_of_a_table.svg Update README.md Add dedicated ISSUE TEMPLATEs Update README.md Delete README.Rmd Update intro-creating-gt-tables.Rmd Update LICENSE Make corrections to docs (`columns`/`rows`) Update _pkgdown.yml Fixes to footer (footnotes and source notes) across all output formats (#864) Row group labels as a column in stub (#855) Use reusable GHA workflows (#847) Increment version number v0.3.1 Release Candidate (#821) Fix for styles applied to summary cells when row groups are reordered (#814) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow the use of shorthand hexadecimal color values (e.g,
#333) , and, the use of thetransparentcolor name.Fixes: #856
Fixes: #839