Add ability to have unlimited column spanners #905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcheng5
reviewed
Mar 8, 2022
jcheng5
reviewed
Mar 8, 2022
jcheng5
reviewed
Mar 8, 2022
jcheng5
reviewed
Mar 8, 2022
* master: Honor default `locale` setting when rendering summary rows (#907)
jcheng5
reviewed
Mar 10, 2022
jcheng5
reviewed
Mar 10, 2022
jcheng5
reviewed
Mar 10, 2022
jcheng5
reviewed
Mar 10, 2022
R/tab_create_modify.R
Outdated
| spanners_existing <- | ||
| spanners_existing %>% | ||
| dplyr::select(spanner_id, vars, spanner_level) | ||
| for (i in seq_len(nrow(spanners_tbl))) { |
Member
There was a problem hiding this comment.
Just a thought, take it or leave it:
highest_level <- spanners_tbl %>%
dplyr::filter(vapply(vars, function(x) any(spanned_vars %in% x), logical(1))) %>%
dplyr::pull("spanner_level") %>%
max()
Member
Author
There was a problem hiding this comment.
I wasn't able to get this to work with the current tests in place. Could you make this a code suggestion? Perhaps I didn't integrate this correctly.
Co-authored-by: Joe Cheng <joe@rstudio.com>
jcheng5
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR revises the
tab_spanner()andtab_spanner_delim()functions so that there is no hard limit for only one level of spanner labels.Fixes: #746