Add small collection of sub_*() functions#912
Merged
rich-iannone merged 73 commits intomasterfrom May 22, 2022
Merged
Conversation
Member
|
Note to self, advantages of
|
jcheng5
reviewed
May 17, 2022
jcheng5
reviewed
May 17, 2022
jcheng5
reviewed
May 17, 2022
jcheng5
reviewed
May 17, 2022
jcheng5
reviewed
May 20, 2022
jcheng5
reviewed
May 20, 2022
jcheng5
reviewed
May 20, 2022
jcheng5
approved these changes
May 20, 2022
beansrowning
added a commit
to CDCgov/SaviR
that referenced
this pull request
May 25, 2022
- See rstudio/gt#912 - quoted columns not passed thru to sub_missing, throwing error in vignette production on CI pipeline - Requiring gt >=0.6, fmt_missing -> sub_missing
rich-iannone
added a commit
that referenced
this pull request
Sep 7, 2022
Incorrect code was added in #912 and the order is reversed (so the conditional always prepends existing formatter list with new formatting directives).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
sub_*()group of functions are meant to make simple and common substitutions of data in a gt table with not-too-much effort. The functions added are:sub_missing()sub_zero()sub_small_vals()sub_large_vals()The
sub_missing()function will replacefmt_missing()(deprecating the latter function).Fixes #904
Fixes #910
Fixes #911