Allow addition of footnotes without supplying any locations#925
Merged
Conversation
locationslocations
jcheng5
reviewed
Apr 22, 2022
jcheng5
approved these changes
Apr 22, 2022
rich-iannone
added a commit
that referenced
this pull request
Apr 27, 2022
* master: (36 commits) Update documentation `devtools::document()` (GitHub Actions) Improve layout of examples in documentation (#933) Allow addition of footnotes without supplying any `locations` (#925) Increment version number to 0.5.0.9000 (#932) v0.5.0 Release Candidate (#931) Fix for adding summary row styles and footnotes (#924) Update _pkgdown.yml Rename as `fmt_partsper()`; refactor Enhance the `cols_merge_uncert()` function (#888) Allow summary rows to be generated in the case of all-`NA` columns (#887) Add several testthat tests Make corrections/additions to RTF marks Update help files using roxygen Update documentation Update help files using roxygen Update _pkgdown.yml Update NAMESPACE Rename function Renumber formatter functions ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We sometimes find that notes in the footnotes section can be without reference to any particular part of the table. Most often, these notes without marks precede those that do contain marks (it would be confusing to mix the marked and unmarked notes together in any other way, especially if they appear in paragraph form).
This PR makes it so that the default locations parameter is
NULLand afootnote(still a required argument) will have no reference to a table cell. The order oftab_footnote()calls is still preserved but is split between location-based footnotes and the non-location variety (which always appears first).Here is an example:
Fixes: #879