Improve implementation of all vec_*() functions#995
Merged
rich-iannone merged 57 commits intomasterfrom Aug 5, 2022
Merged
Conversation
…into remove-html-entities
rich-iannone
changed the title
vec_*() functions
…into remove-html-entities
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
vec_*()series of functions is useful for creating formatted values from vectors (totally independent of using tables, which is great for formatting values in an R Markdown or Quarto doc). Here, we include a"plain"outputoption. It can use Unicode characters and is suitable for printing in the R console. We also now have an"auto"output option (the default) which will determine the output context (e.g., Quarto rendering a PDF document) and choose the output, defaulting to"plain"in the interactive case.This PR also continues the work on using preferring the use of Unicode characters instead of HTML entities to represent certain non-ASCII characters (e.g., multiplication sign, minus sign, etc.).
The use of CSS classes in formatted values was limited since the classes used are inaccessible outside of a table context. For example, when using
vec_fmt_scientific()with a vector of numeric values, a class would be present in the output and it likely wouldn't be available when embedding the output values in an HTML document. This is solved by inlining CSS styles to the relevantstyleattribute.