-
Notifications
You must be signed in to change notification settings - Fork 218
Improve stub with indentation options and better default alignments #999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cscheid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the kind of thing that's best done by adding a new concept ("indent") or should it be left to user CSS instead?
|
IMO it’s far better to make this first class with its own function since it’s meant to establish structure and the implementation is different across output types. |
cscheid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
This PR focuses on some first steps to improving the appearance and functionality of the gt table stub.
The first fixes (a prelude, really) involve improving the default alignments of content in the stub. With the stub serving either as row labels or indices, it's important to discern which is which and this is done as part of the auto-alignment routine in the
gt()function.The main thing after that is to introduce the first-class ability to set indentation on the stub elements. This is important enough to require a new function with a specialized interface for this task (
tab_stub_indent()).Here is a runnable example that demonstrates one use of
tab_stub_indent():