Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when running exercise code #229

Closed
schloerke opened this issue Apr 25, 2019 · 1 comment
Assignees
Milestone

Comments

@schloerke
Copy link
Collaborator

@schloerke schloerke commented Apr 25, 2019

This shuts down whole tutorial.

@schloerke schloerke added this to the 0.10.0 milestone Apr 25, 2019
@schloerke schloerke self-assigned this Apr 25, 2019
@adamblake

This comment has been minimized.

Copy link
Contributor

@adamblake adamblake commented Jun 1, 2019

I think this is only true for certain errors, like syntax errors:

1:

My solution was to create a custom evaluator that just adds a tryCatch() around the result. I'll make a pull request and tag this issue.

Edit, to clarify: the custom evaluator was for my own files. This commit (d6ab4d7) adds the fail safe to the exercise evaluator.

adamblake added a commit to adamblake/learnr that referenced this issue Jun 3, 2019
@schloerke schloerke closed this Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.