Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDisplay full HTML messages if provided by the `incorrect` or the `correct` args to `question() ` #146
Conversation
… `correct`) arguments to `question()`. previously, we were grabbing the .text(), which stripped the html rich formatting.
|
@mine-cetinkaya-rundel, can you confirm that installing this branch fixes your use case from #136: |
|
Yes, this looks good to me! |
|
yup, it's working for me too, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This was a quick fix on the JS side: essentially grab the .html() provided by the
incorrect(and thecorrect) arguments toquestion(). Previously, we were grabbing the .text(), which stripped the html rich formatting when provided.@jjallaire, this seemed like low hanging fruit for this release. Let me know if you think that it risks regression or anything else I might have overlooked.
Closes #136.