Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAggressive Prerender checks within rmarkdown #179
Conversation
|
Will require a followup PR to remove the reference in the DESCRIPTION file once rmarkdown is released to CRAN |
|
One scenario we should be sure to encompass is to be able to run tutorials in an environment where they are never rendered (we need this e.g. for Shiny Server when they are deployed in a readonly directory). Is that still possible? |
|
Can still execute this to never prerender: withr::with_envvar(c(RMARKDOWN_RUN_PRERENDER = "0"), {
learnr::run_tutorial(FILE, package = PKG)
})Would it be better to have a learnr::run_tutorial_local(FILE, package = PKG) |
|
No, I think it's fine as long as rmarkdown has that hook. |
| @@ -1,8 +1,11 @@ | |||
| learnr 0.9.3 | |||
| learnr 0.9.3 (unreleased) | |||
wch
Aug 13, 2018
Collaborator
0.9.2.9000
0.9.2.9000
Will keep as remote until rmarkdown releases to CRAN
* master: Aggressive Prerender checks within rmarkdown (rstudio#179)
Fixes #169
Uses rstudio/rmarkdown#1420 to rerender tutorials if any html dependency package version is different and if any package used to build the document is different at run time.
Because this is so aggressive and the checks should be done every time a user runs the document, setting the environment variable
RMARKDOWN_RUN_PRERENDER=0should not be done.