Skip to content

/ learnr

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tabset support #219

Merged
merged 4 commits into from Apr 10, 2019
Merged

Add tabset support #219

merged 4 commits into from Apr 10, 2019

Conversation

@schloerke
Copy link
Collaborator

@schloerke schloerke commented Apr 4, 2019 •
edited

Fixes #212
schloerke added 2 commits Apr 4, 2019
@schloerke
use rmarkdown::html_document and copy in tabset template code from rm…
7d1e5b8 
…arkdown
@schloerke
added tabset support
b3494f0
@schloerke schloerke force-pushed the tabset branch from 0640fa5 to b3494f0 Apr 4, 2019
@schloerke schloerke requested a review from jcheng5 Apr 4, 2019
@schloerke
Merge branch 'master' into tabset
830b588 
* master:
  Bump rmarkdown version to >= v1.12.0 (#220)
@jcheng5
Copy link
Member

@jcheng5 jcheng5 commented Apr 4, 2019

Can you add a comment to the HTML indicating where the CSS came from? Other than that, LGTM.
@schloerke
add comments about original tabset location
4307dbe
@schloerke schloerke merged commit 7508f41 into master Apr 10, 2019
@schloerke schloerke deleted the tabset branch Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcheng5 jcheng5

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@schloerke @jcheng5
You can’t perform that action at this time.