Skip to content

/ learnr

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retrieve last value from evaluating exercises. Pass this to `checker` functions #228

Merged
merged 7 commits into from May 17, 2019
Merged

Retrieve last value from evaluating exercises. Pass this to `checker` functions #228

merged 7 commits into from May 17, 2019

Conversation

@schloerke
Copy link
Collaborator

@schloerke schloerke commented Apr 25, 2019

Fixes #198
schloerke added 3 commits Apr 25, 2019
@schloerke
first pass at using last_value to checker function
199b0f1
@schloerke
only pass in extra args to the default output handler value fn if it …
0914431 
…handles them
@schloerke
use correct args
15547e3
@schloerke
Copy link
Collaborator Author

@schloerke schloerke commented Apr 25, 2019

small round trip test with grader works
@schloerke schloerke requested a review from wch Apr 25, 2019
@wch
wch reviewed May 13, 2019
View changes
R/exercise.R Outdated Show resolved Hide resolved
schloerke added 3 commits May 14, 2019
@schloerke
Merge branch 'master' into last_result
82ea6c6 
* master:
  Fix Travis (#231)
  Require packrat dev version (#230)
@schloerke
clean up logic to match evaluate.
f71ac0d 
if there is a second argument, pass it in, otherwise call like normal with the x value.

Rename variable for clarity
@schloerke
News item for last_value
Loading status checks…
aee5d6e
@schloerke schloerke requested a review from wch May 14, 2019
@wch
wch approved these changes May 14, 2019
View changes
@schloerke
Merge branch 'master' into last_result
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8f1d0ab
@schloerke schloerke merged commit 88ea0dd into master May 17, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@schloerke schloerke deleted the last_result branch May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wch wch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

use result of last statement in exercise.checker function
2 participants
@schloerke @wch
You can’t perform that action at this time.