Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace checkthis and grader with gradethis in docs #269

Closed

Conversation

@chendaniely
Copy link

chendaniely commented Aug 1, 2019

Replaced the tutorial option from checkthis to knitr exercise.checker gradethis

fixes #233

@chendaniely chendaniely force-pushed the chendaniely:checkthat_docs_fixes#233 branch from 2c7c6e0 to ec11b4a Aug 1, 2019
Copy link
Collaborator

schloerke left a comment

There are still references to checkthat. gradethis is now a full fledge package and should not be presented as a "oh by the way... gradethis exists".

In the paragraph above the edits made in exercise.Rmd, replace all mentions of checkthat for grader. Maybe merge the two paragraphs?

Edit the exercisecheck snippet to be gradethis

@schloerke

This comment has been minimized.

Copy link
Collaborator

schloerke commented Aug 1, 2019

exercisecheck location - ./docs/snippets/exercisecheck.md

Copy link
Author

chendaniely left a comment

Should've fixed up the remaining missing gradethis references

schloerke and others added 3 commits Aug 1, 2019
…rnr into checkthat_docs_fixes#233
@schloerke schloerke added this to the 0.10.0 milestone Aug 2, 2019
@schloerke schloerke requested a review from wch Aug 6, 2019
@CLAassistant

This comment has been minimized.

Copy link

CLAassistant commented Oct 2, 2019

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.