Skip to content

/ learnr

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace checkthis and grader with gradethis in docs #269

Closed
wants to merge 5 commits into from
Closed

replace checkthis and grader with gradethis in docs #269

wants to merge 5 commits into from

Conversation

@chendaniely
Copy link

@chendaniely chendaniely commented Aug 1, 2019 •
edited

Replaced the tutorial option from checkthis to knitr exercise.checker gradethis

fixes #233
@chendaniely
replace checkthis and grader with gradethis in docs
Loading status checks…
ec11b4a
@chendaniely chendaniely force-pushed the chendaniely:checkthat_docs_fixes#233 branch from 2c7c6e0 to ec11b4a Aug 1, 2019
@schloerke
schloerke requested changes Aug 1, 2019
View changes
Copy link
Collaborator

@schloerke schloerke left a comment

There are still references to checkthat. gradethis is now a full fledge package and should not be presented as a "oh by the way... gradethis exists".

In the paragraph above the edits made in exercise.Rmd, replace all mentions of checkthat for grader. Maybe merge the two paragraphs?

Edit the exercisecheck snippet to be gradethis
@schloerke
Copy link
Collaborator

@schloerke schloerke commented Aug 1, 2019

exercisecheck location - ./docs/snippets/exercisecheck.md
@chendaniely
add and fix more gradethis references
Loading status checks…
49e695a
@chendaniely
chendaniely reviewed Aug 1, 2019
View changes
Copy link
Author

@chendaniely chendaniely left a comment

Should've fixed up the remaining missing gradethis references
schloerke and others added 3 commits Aug 1, 2019
@schloerke
Update NEWS.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f531751
@chendaniely
remove site_libs, re-knit examples, formats, index, publishing, quest…
ecbe94a 
…ions, exercises Rmd
@chendaniely
Merge branch 'checkthat_docs_fixes#233' of github.com:chendaniely/lea…
Loading status checks…
d653ab3 
…rnr into checkthat_docs_fixes#233
@schloerke schloerke added this to the 0.10.0 milestone Aug 2, 2019
@schloerke schloerke requested a review from wch Aug 6, 2019
@schloerke schloerke mentioned this pull request Aug 7, 2019
Merged
@CLAassistant
Copy link

@CLAassistant CLAassistant commented Oct 2, 2019 •
edited

CLA assistant check
All committers have signed the CLA.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schloerke schloerke

@wch wch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10.0
Linked issues

Successfully merging this pull request may close these issues.

there is no package called ‘checkthat’
3 participants
@chendaniely @schloerke @CLAassistant
You can’t perform that action at this time.