Skip to content

/ learnr

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not reset question submissions #270

Merged
merged 4 commits into from Aug 7, 2019
Merged

Do not reset question submissions #270

merged 4 commits into from Aug 7, 2019

Conversation

@schloerke
Copy link
Collaborator

@schloerke schloerke commented Aug 6, 2019 •
edited

When questions are tried again, the existing answer will remain.

Before this PR, when questions where initialized, they were always initialized with a NULL answer. If the user was to get the answer wrong and try again, the question would be completely reset. This PR makes it so that the question is reset, but the existing answer remains.

PR task list:

  • Update NEWS
  • [NA] Add tests (if possible)
  • Update documentation with devtools::document()
schloerke added 4 commits Aug 6, 2019
@schloerke
when questions are tried again, the existing answer will remain
Loading status checks…
9383db2
@schloerke
fix news bug number
Loading status checks…
b2afead
@schloerke
isolate on input$answer when displaying question_ui_initialize
Loading status checks…
3a1a539
@schloerke
update comment
Loading status checks…
e1bc97e
@wch
wch approved these changes Aug 7, 2019
View changes
@schloerke schloerke merged commit d06e6a9 into master Aug 7, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@schloerke schloerke deleted the no_reset_question branch Aug 7, 2019
schloerke added a commit that referenced this pull request Aug 7, 2019
@schloerke
Merge branch 'master' into rc-v0.10.0
97ccd5d 
* master:
  Do not reset question submissions (#270)
  only display visible output in exercise (#268)
This was referenced Oct 28, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wch wch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@schloerke @wch
You can’t perform that action at this time.