Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a version for question_submission events. Add boxes to quiz questions #291

Merged
merged 10 commits into from
Oct 31, 2019
Merged

Use a version for question_submission events. Add boxes to quiz questions #291

merged 10 commits into from
Oct 31, 2019

Conversation

schloerke
Copy link
Collaborator

@schloerke schloerke commented Oct 28, 2019 •
edited
Loading

Follow up to #276

PR task list:

  • Update NEWS
  • [NA] Add tests (if possible)
  • [NA] Update documentation with devtools::document()

@schloerke schloerke added this to the 0.10.0 milestone Oct 28, 2019
@schloerke schloerke self-assigned this Oct 28, 2019
@schloerke schloerke requested a review from wch October 28, 2019 16:43
wch
wch reviewed Oct 28, 2019
View reviewed changes
R/storage.R Outdated Show resolved Hide resolved
wch
wch reviewed Oct 28, 2019
View reviewed changes
R/storage.R Outdated Show resolved Hide resolved
@schloerke
move else to proper place
f69ae30
@schloerke
api_version <- version
2c0de40
@schloerke
Merge branch 'master' into disk_answers
4254325 
* master:
  remove bad pkg names when finding deps (#292)
@schloerke
Merge branch 'master' into disk_answers
7c6c0eb 
* master:
  Move examples into tutorials and update website (#294)
  fix message logic for checkbox questions and html output in question messages (#299)
  Enable Mathjax in quiz questions (#281)
  Maintain knitr's output handler (#288)
@schloerke
Merge branch 'master' into disk_answers
53dbf83 
* master:
  add last_value in exercise docs (#301)
@schloerke
do not require dev version of renv
e697d0f
@schloerke
safe guard against null objects
abf8415
@schloerke
display questions in same box as before
abf325f
@schloerke schloerke merged commit 01e2d8b into master Oct 31, 2019
@schloerke schloerke deleted the disk_answers branch October 31, 2019 20:32
@schloerke schloerke changed the title Use a version for question_submission events Use a version for question_submission events. Add boxes to quiz questions Oct 31, 2019
schloerke added a commit that referenced this pull request Oct 31, 2019
@schloerke
Merge branch 'master' into rc-v0.10.0
1dbf83e 
* master:
  Remove checkthat and replace with gradethis (#273)
  Use a version for `question_submission` events. Add borders around quiz questions (#291)
  add last_value in exercise docs (#301)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wch wch wch left review comments

Assignees

@schloerke schloerke

Labels
None yet
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@schloerke @wch