Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use indexedDB directly via idb-keyval #305

Merged
merged 11 commits into from Nov 6, 2019

Conversation

@schloerke
Copy link
Collaborator

schloerke commented Nov 6, 2019

Fixes #304
Fixes #302

(View diff with white space turned off.)

Notes:
https://github.com/rstudio/learnr/pull/305/files?utf8=✓&diff=split&w=1#diff-c7d58e72ba1e4c97d7f872330fd63d87R1473-R1494

PR task list:

  • Update NEWS
  • [NA] Add tests (if possible)
  • [NA] Update documentation with devtools::document()
  • Update authors in DESCRIPTION

Includes code from https://github.com/jakearchibald/idb-keyval/pull/73/files#diff-32d9810b60fe9355ae31121d8cc181e2

schloerke added 3 commits Nov 6, 2019
All store interactions must open store, do work on store, then close store
@schloerke schloerke added this to the 0.10.0 milestone Nov 6, 2019
@schloerke schloerke self-assigned this Nov 6, 2019
@schloerke schloerke requested a review from wch Nov 6, 2019
NEWS.md Outdated Show resolved Hide resolved
inst/lib/tutorial/tutorial.js Outdated Show resolved Hide resolved
inst/lib/tutorial/tutorial.js Outdated Show resolved Hide resolved
@wch

This comment has been minimized.

Copy link
Collaborator

wch commented Nov 6, 2019

We should also include license information for idb-keyval.

@wch
wch approved these changes Nov 6, 2019
@schloerke schloerke merged commit 2150928 into master Nov 6, 2019
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
license/cla Contributor License Agreement is signed.
Details
@schloerke schloerke deleted the raw_idb branch Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.