Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse indexedDB directly via idb-keyval #305
Merged
Conversation
All store interactions must open store, do work on store, then close store
|
We should also include license information for idb-keyval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes #304
Fixes #302
(View diff with white space turned off.)
Notes:
https://github.com/rstudio/learnr/pull/305/files?utf8=✓&diff=split&w=1#diff-c7d58e72ba1e4c97d7f872330fd63d87R1473-R1494
PR task list:
devtools::document()Includes code from https://github.com/jakearchibald/idb-keyval/pull/73/files#diff-32d9810b60fe9355ae31121d8cc181e2