Use `.on("load", fn)` as `.load(fn)` has been deprecated #326

schloerke · 2020-02-09T23:32:07Z

Fixes #315

PR task list:

Update NEWS
[NA] Add tests (if possible)
[NA] Update documentation with devtools::document()

trestletech

I don't have a video-based tutorial handy, so I didn't test this myself. But it seems sensible based on the point you made about jQuery 3.

* master: implement tutorial_package_dependencies() (#329) Fix progressive reveal and Topics with special characters not loading (#330) Remove dead event, clarify Rmd/HTML docs (#331) Add session start/stop events (#328) Use `.on("load", fn)` as `.load(fn)` has been deprecated (#326)

Use `.on("load", fn)` as `.load(fn)` has been deprecated

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

Loading status checks…

b14be2e

schloerke self-assigned this Feb 9, 2020

add news item

Loading status checks…

3ff1510

schloerke requested review from trestletech and wch Feb 9, 2020

trestletech approved these changes Feb 10, 2020

View changes

wch approved these changes Feb 10, 2020

View changes

schloerke deleted the jquery-onload branch Feb 10, 2020

rstudio / learnr

Use `.on("load", fn)` as `.load(fn)` has been deprecated #326

Use `.on("load", fn)` as `.load(fn)` has been deprecated #326

schloerke commented Feb 9, 2020 •

edited

trestletech left a comment

rstudio / learnr

Join GitHub today

Use `.on("load", fn)` as `.load(fn)` has been deprecated #326

Use `.on("load", fn)` as `.load(fn)` has been deprecated #326

Conversation

schloerke commented Feb 9, 2020 • edited

trestletech left a comment

Essential cookies

Always active

Analytics cookies

schloerke commented Feb 9, 2020 •

edited