Skip to content

/ learnr

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement tutorial_package_dependencies() #329

Merged
merged 12 commits into from Feb 12, 2020
Merged

implement tutorial_package_dependencies() #329

merged 12 commits into from Feb 12, 2020

Conversation

@kevinushey
Copy link
Collaborator

@kevinushey kevinushey commented Feb 11, 2020

For front-ends that might want to enumerate a tutorial's required R package dependencies.

This is admittedly quick-and-dirty; @schloerke let me know if this looks okay or if you'd prefer some tweaks.
kevinushey added 2 commits Feb 11, 2020
@kevinushey
implement tutorial_dependencies()
5d220f1
@kevinushey
add unit test
Loading status checks…
8d6a7e5
@kevinushey
kevinushey reviewed Feb 11, 2020
View changes
NAMESPACE Outdated Show resolved Hide resolved
schloerke added 5 commits Feb 11, 2020
@schloerke
rename file
311bc20
@schloerke
Move files into one place and unify renv call to a single function
db73a29
@schloerke
allow for tutorial_package_dependencies to work like available_packages
Loading status checks…
09316d3
@schloerke
document available tutorials. Add new column package_dependencies. Ha…
Loading status checks…
7c6e45d 
…ve tutorial_package_dependencies call available_tutorials if needed. Skip tests if learnr isn't installed
@schloerke
return NULL for test and older R versions
Loading status checks…
b8bce3e
@schloerke schloerke self-assigned this Feb 12, 2020
@schloerke schloerke requested a review from wch Feb 12, 2020
@schloerke
Copy link
Collaborator

@schloerke schloerke commented Feb 12, 2020

Two major changes.

  • Adds column package_dependencies to available_tutorials() output
  • Adds function tutorial_package_dependencies()
@wch
wch reviewed Feb 12, 2020
View changes
Copy link
Collaborator

@wch wch left a comment

I had a few comments on this PR. There's also a test that's failing on older versions of R:
https://github.com/rstudio/learnr/pull/329/checks?check_run_id=441404857#step:9:87
NEWS.md Outdated Show resolved Hide resolved
R/tutorial_package_dependencies.R Outdated Show resolved Hide resolved
R/tutorial_package_dependencies.R Outdated Show resolved Hide resolved
tests/testthat/test-dependency.R Outdated Show resolved Hide resolved
schloerke added 5 commits Feb 12, 2020
@schloerke
Correct the news item and add the PR
0a32628
@schloerke
Remove unneeded skip check
7b02cb0
@schloerke
Trim white space
20da416
@schloerke
Reflow tutorial_package_dependencies() docs. Fix incorrect word
e05df52
@schloerke
Preempt if there are no deps found. R <= 3.4 can not `sort(NULL)`
Loading status checks…
a6d06f3
@schloerke schloerke self-requested a review Feb 12, 2020
@schloerke
schloerke approved these changes Feb 12, 2020
View changes
@schloerke schloerke requested review from wch and removed request for wch Feb 12, 2020
@schloerke schloerke dismissed wch’s stale review Feb 12, 2020

Need to merge PR

@schloerke schloerke changed the title implement tutorial_dependencies() implement tutorial_package_dependencies() Feb 12, 2020
@schloerke schloerke merged commit 89c1d14 into master Feb 12, 2020
9 checks passed
9 checks passed
windows-latest (3.6) windows-latest (3.6)
Details
windows-latest (devel)
Details
macOS-latest (3.6)
Details
ubuntu-16.04 (3.2)
Details
ubuntu-16.04 (3.3)
Details
ubuntu-16.04 (3.4)
Details
ubuntu-16.04 (3.5)
Details
ubuntu-16.04 (3.6)
Details
license/cla Contributor License Agreement is signed.
Details
@schloerke schloerke deleted the feature/tutorial-dependencies branch Feb 12, 2020
schloerke added a commit that referenced this pull request Feb 12, 2020
@schloerke
Merge branch 'master' into v0.10.1-rc
c5abcac 
* master:
  implement tutorial_package_dependencies() (#329)
  Fix progressive reveal and Topics with special characters not loading (#330)
  Remove dead event, clarify Rmd/HTML docs (#331)
  Add session start/stop events (#328)
  Use `.on("load", fn)` as `.load(fn)` has been deprecated (#326)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schloerke schloerke

@wch wch

Assignees

@schloerke schloerke

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@kevinushey @schloerke @wch
You can’t perform that action at this time.