Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix progressive reveal and Topics with special characters not loading #330

Merged
merged 4 commits into from Feb 12, 2020

Conversation

@schloerke
Copy link
Collaborator

@schloerke schloerke commented Feb 11, 2020

Fixes #320
Fixes #319

For #320, there was never a call to notify the js data model that the section had actually been skipped.

For #319, the hash was being returned as window.encodeURI output. By passing it through window.decodeURI, it behaves as expected.

File to test with
---
title: "learnr#330"
output:
  learnr::tutorial:
    progressive: true
    allow_skip: true
runtime: shiny_prerendered
---


## Section 1

### Subtopic 1

text

### Subtopic 2.

text

### Subtopic 3

text

## Säction title

### Subtopic 4

text

### Subtopic 5.

text

### Subtopic 6

text

  • Should be able to click continue and also view the second section.
@schloerke schloerke self-assigned this Feb 11, 2020
@schloerke schloerke requested a review from wch Feb 12, 2020
@wch
wch approved these changes Feb 12, 2020
@schloerke schloerke merged commit 6620c67 into master Feb 12, 2020
9 checks passed
9 checks passed
windows-latest (3.6)
Details
windows-latest (devel)
Details
macOS-latest (3.6)
Details
ubuntu-16.04 (3.2)
Details
ubuntu-16.04 (3.3)
Details
ubuntu-16.04 (3.4)
Details
ubuntu-16.04 (3.5)
Details
ubuntu-16.04 (3.6)
Details
license/cla Contributor License Agreement is signed.
Details
@schloerke schloerke deleted the progressive_reveal branch Feb 12, 2020
schloerke added a commit that referenced this pull request Feb 12, 2020
* master:
  implement tutorial_package_dependencies() (#329)
  Fix progressive reveal and Topics with special characters not loading (#330)
  Remove dead event, clarify Rmd/HTML docs (#331)
  Add session start/stop events (#328)
  Use `.on("load", fn)` as `.load(fn)` has been deprecated (#326)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.