Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page numbers disappeared from page reference #120

Closed
atusy opened this issue Jul 9, 2019 · 8 comments
Closed

Page numbers disappeared from page reference #120

atusy opened this issue Jul 9, 2019 · 8 comments
Labels
bug an unexpected problem or unintended behavior

Comments

@atusy
Copy link
Contributor

atusy commented Jul 9, 2019

As far as I checked by rendering inst/examples/index.Rmd, the page numbers disappeared since 216c09a.

Below is a screenshot of current https://pagedown.rbind.io/#page-references

image

@yihui
Copy link
Member

yihui commented Jul 14, 2019

@RLesur After this issue is resolved, I'd like to upload a new version of pagedown to CRAN because it has been almost half a year since the last update. No hurry, though.

@RLesur
Copy link
Collaborator

RLesur commented Jul 14, 2019

@yihui We are sync. I precisely wanted to inspect this issue today before going on holidays.

@RLesur
Copy link
Collaborator

RLesur commented Jul 14, 2019

@atusy Thanks a lot for having spotted the exact commit. This was super helpful!
The problem comes more precisely from 216c09a#diff-b2e946e796db5bbbe9e9b33dd905e4b7L184
I don't know why I've removed this <div>. Sorry for that!

There's another problem to fix: with Pandoc 2.7.3, <a></a> elements are present in code blocks. Therefore, the CSS introduces pages reference in code blocks like that:

pandoc273

@atusy
Copy link
Contributor Author

atusy commented Jul 14, 2019

Thank you, too!!
I locally checked it works now 😄

@yihui
Copy link
Member

yihui commented Jul 14, 2019

@RLesur Perfect! Please let me know whenever you feel you are ready for the next release, and I'll upload it to CRAN. We certainly don't have to address all issues. I think we have had enough items in NEWS.md that can warrant a CRAN update.

@RLesur
Copy link
Collaborator

RLesur commented Jul 14, 2019

@yihui I will leave tomorrow and won't be able to contribute to open source projects for three weeks.
I think you can release 0.3 when you want.

@yihui
Copy link
Member

yihui commented Jul 15, 2019

Sounds good. Thank you!

@yihui
Copy link
Member

yihui commented Jul 15, 2019

@RLesur FYI, pagedown v0.3 is on CRAN now.

@yihui yihui added the bug an unexpected problem or unintended behavior label Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

3 participants