Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong page references in table of contents #35

Closed
RLesur opened this issue Dec 14, 2018 · 6 comments
Closed

Wrong page references in table of contents #35

RLesur opened this issue Dec 14, 2018 · 6 comments

Comments

@RLesur
Copy link
Collaborator

RLesur commented Dec 14, 2018

Since Paged.js 0.1.28 (3168deb), the page numbering in TOC is wrong when we use a TOC depth greater than 1. This happens only with Chrome, not Firefox.
I declared the issue in the Paged.js project: https://gitlab.pagedmedia.org/tools/pagedjs/issues/89

@RLesur
Copy link
Collaborator Author

RLesur commented Dec 22, 2018

It is fixed in Paged.js 0.1.29 https://gitlab.pagedmedia.org/tools/pagedjs/issues/89#note_502
However, I get a regression with 0.1.29 (see the page number of the lists of figures and tables):
paged js-0 1 29

@yihui
Copy link
Member

yihui commented Dec 22, 2018

Actually the LOT and LOF are usually not included in the TOC. If you are able to remove these two items from the TOC, that will be great.

@RLesur
Copy link
Collaborator Author

RLesur commented Dec 22, 2018

I can try to remove LOT and LOF from the TOC.
However, this will lead to a difference with the LaTeX CRC template where LOT and LOF are referenced in the TOC: https://bookdown.org/yihui/bookdown/bookdown.pdf.
The bug will remain for any section of class front-matter.

@yihui
Copy link
Member

yihui commented Dec 23, 2018

Oh I misremembered. Sorry. Then let's keep them.

@RLesur
Copy link
Collaborator Author

RLesur commented Mar 23, 2019

However, I get a regression with 0.1.29 (see the page number of the lists of figures and tables):

I finally found the problem: this is a Chrome redraw issue. This seems to be a well-known bug.
There are many available hacks to solve this problem (try to Google Chrome redraw issue). Only this one works for me with Chromium/Ubuntu.

I will upgrade Paged.js to 0.1.31 soon. There is one breaking change (Paged.js CSS variables are now prefixed) but there are many improvements. IMO the most important ones are the fix for page references and the support for the marks property.

@RLesur RLesur closed this as completed in d6d8aad Mar 23, 2019
@yihui
Copy link
Member

yihui commented Mar 25, 2019

Excellent. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants