Skip to content

pin + github_board creates new commit for each file additional file #197

@cboettig

Description

@cboettig

@javierluraschi pointed out to me in #170 that if you pass a vector of files to pin() and have set the threshold size options(pins.github.release = 0) to force all uploads to release assets, then they all go on the same release.

I was thus surprised to see that if I pass a vector of objects to pin where I'm using the default size threshhold (and all objects are nice and small) when using a github_board, pin creates a new commit for each object. It would be nice if possible to have all these files committed in a single commit. This is probably relevant for versioning (#178) and more immediately, the current setup makes it very very slow for a large vector of small files. (Though on the flip side, pin() with threshold set to 0 just fails when I try to send a lot of objects at once).

(in other words: whoopsies, did I just make 2913 commits? 🙋‍♂ 😊 )

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions