Fix cache_prune() and friends for board_url()
#734
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #607
This PR recurses just a little in the board caches to find all the possible pin version directories, including the
board_url()ones. Unlike now, whenpins:::cache_old()does not findboard_url()caches, with this PR we can:Created on 2023-04-18 with reprex v2.0.2
Interactively, I can now say "Yes" and then the pruning works. 👍
Unless I am mistaken, I don't think we are testing this caching code anywhere in the package. Let's consider how we might test that in a separate issue/PR and only focus on fixing this bug here.