Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add router modifier tag support (#' @plumber) #568

Merged
merged 8 commits into from Jun 26, 2020
Merged

Add router modifier tag support (#' @plumber) #568

merged 8 commits into from Jun 26, 2020

Conversation

meztez
Copy link
Collaborator

@meztez meztez commented Jun 24, 2020

Add support for a @plumber tag that use the expr to modify the plumber router programmatically.

#* @plumber
function(pr){
  pr$handle("GET", "/avatartare", function(raw) {raw}, serializer = serializer_json)
}

PR task list:

  • Update NEWS
  • Add tests
  • Update documentation with devtools::document()

@schloerke
Copy link
Collaborator

I'm so excited for this PR. Thank you @meztez !

cc @blairj09

schloerke
schloerke reviewed Jun 25, 2020
View reviewed changes
NEWS.md Outdated Show resolved Hide resolved
schloerke
schloerke reviewed Jun 25, 2020
View reviewed changes
R/plumb-block.R Outdated Show resolved Hide resolved
schloerke
schloerke reviewed Jun 25, 2020
View reviewed changes
R/plumb-block.R Outdated Show resolved Hide resolved
schloerke
schloerke reviewed Jun 25, 2020
View reviewed changes
R/plumb-block.R Outdated Show resolved Hide resolved
meztez and others added 4 commits June 25, 2020 10:54
@meztez @schloerke
Update NEWS.md
649eb24 
Co-authored-by: Barret Schloerke <barret@rstudio.com>
@meztez @schloerke
Update R/plumb-block.R
463f59e 
Co-authored-by: Barret Schloerke <barret@rstudio.com>
@meztez @schloerke
Update R/plumb-block.R
e6e39fb 
Co-authored-by: Barret Schloerke <barret@rstudio.com>
@schloerke
Merge branch 'master' into router_modifier_tag
41c2880
cpsievert
cpsievert reviewed Jun 25, 2020
View reviewed changes
NEWS.md Outdated Show resolved Hide resolved
@meztez @cpsievert
Update NEWS.md
cf1466a 
Co-authored-by: Carson Sievert <cpsievert1@gmail.com>
cpsievert
cpsievert reviewed Jun 25, 2020
View reviewed changes
R/plumb-block.R Outdated Show resolved Hide resolved
@meztez @cpsievert
Update R/plumb-block.R
9633a9c 
Co-authored-by: Carson Sievert <cpsievert1@gmail.com>
@cpsievert cpsievert self-requested a review June 25, 2020 20:12
cpsievert
cpsievert approved these changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@cpsievert cpsievert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@schloerke schloerke changed the title add router modifier tag support (#* @plumber) Add router modifier tag support (#' @plumber) Jun 26, 2020
@schloerke schloerke merged commit 43067ff into rstudio:master Jun 26, 2020
schloerke added a commit that referenced this pull request Jun 26, 2020
@schloerke
Merge branch 'master' into pkgdown
263fabb 
* master:
  Add router modifier tag support (`#' @plumber`) (#568)
  Clean up print method (#565)
This was referenced Jun 27, 2020
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpsievert cpsievert cpsievert approved these changes

@schloerke schloerke Awaiting requested review from schloerke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@meztez @schloerke @cpsievert