Consolidate swagger type information

[schloerke]

Fixes #351

This consolidates all swagger type information into one location. If a new type is supported in the future, only one spot will need to be added.

[schloerke]

Old:

switch(type,
"bool" = ,	
"logical" = "boolean",

"double" = ,
"numeric" = "number",

"int" = "integer",

"character" = "string"
)

New:

addSwaggerInfo(
  "boolean",
  c("bool", "boolean", "logical"),
  "[01tfTF]|true|false|TRUE|FALSE",
  as.logical
)
addSwaggerInfo(
  "number",
  c("dbl", "double", "float", "number", "numeric"),
  "-?\\\\d*\\\\.?\\\\d+",
  as.numeric
)
addSwaggerInfo(
  "integer",
  c("int", "integer"),
  "-?\\\\d+",
  as.integer
)
addSwaggerInfo(
  "string",
  c("chr", "str", "character", "string"),
  "[^/]+",
  as.character
)

[schloerke]

I am worried about this change. https://github.com/trestletech/plumber/pull/388/files#diff-c6fcef256c9135dbef4ee90414a8074aR54

Should the regex be updated to only look for known types? Or should the regex look for a pattern of <VAR:TYPE> and complain if TYPE is unknown.

[codecov-io]

Codecov Report

Merging #388 into master will increase coverage by 0.03%.
The diff coverage is 98.03%.

@@            Coverage Diff            @@
##           master    #388      +/-   ##
=========================================
+ Coverage   89.26%   89.3%   +0.03%     
=========================================
  Files          29      29              
  Lines        1435    1449      +14     
=========================================
+ Hits         1281    1294      +13     
- Misses        154     155       +1

Impacted Files	Coverage Δ
R/plumber-step.R	88.37% <100%> (ø)	⬆️
R/query-string.R	91.13% <100%> (+0.99%)	⬆️
R/swagger.R	98.55% <92.3%> (-1.45%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0787b8c...12279c6. Read the comment docs.

[schloerke]

This currently will cause an error if a type isn't found.

> tmp <- tempfile("tmp")
> cat(file = tmp, "
+ #* @get /barret/<barret:int>
+ function(req, res) {
+   'barret-int!'
+ }
+ #* @get /barret/<barret:asdf>
+ function(req, res) {
+   'barret-asdf!'
+ }
+ ")
> plumb(tmp)$run(port = 1234)
Error in plumberToSwaggerType(types) : Unrecognized type: asdf

Before, I would at least be able to find the /barret/<barret:int> route. The /barret/<barret:asdf> route was not reachable.