Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error handling in serializer #490

Merged
merged 3 commits into from Sep 30, 2019
Merged

Conversation

antoine-sachet
Copy link
Contributor

@antoine-sachet antoine-sachet commented Sep 11, 2019

The serializer step in plumber was not updated when the errorHandler was put in private. This causes the error handling to fail with object "errorHandler" not found if the serializer fails.

This was a simply typo fix but I added a test anyway. Fixes #489.

PR task list:

  • Update NEWS
  • Add tests
  • Update documentation with devtools::document()

@CLAassistant
Copy link

CLAassistant commented Sep 11, 2019

CLA assistant check
All committers have signed the CLA.

@schloerke schloerke added this to the v0.5.0 - Next CRAN release milestone Sep 30, 2019
@schloerke schloerke self-requested a review Sep 30, 2019
@schloerke schloerke merged commit 2a0e795 into rstudio:master Sep 30, 2019
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

errorHandler "not found" in serializers
3 participants