Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plumber_options() #555

Merged
merged 12 commits into from Jun 23, 2020
Merged

Add plumber_options() #555

merged 12 commits into from Jun 23, 2020

Conversation

meztez
Copy link
Collaborator

@meztez meztez commented Jun 22, 2020

PR task list:

  • Update NEWS
  • Add tests
  • Update documentation with devtools::document()

NEWS.md Outdated Show resolved Hide resolved
@schloerke
Copy link
Collaborator

schloerke commented Jun 22, 2020

@meztez May we combine these functions into a single function? optionsPlumber()

This will follow pattern of options (as well as autocomplete) and not take away from plumber* methods.

@schloerke schloerke added this to the v0.5.0 - Next CRAN release milestone Jun 22, 2020
meztez and others added 3 commits Jun 22, 2020
Co-authored-by: Barret Schloerke <barret@rstudio.com>
Merge branch 'plumber_options' of github.com:meztez/plumber into plumber_options

# Conflicts:
#	NEWS.md
@schloerke schloerke requested a review from cpsievert Jun 23, 2020
meztez added 2 commits Jun 23, 2020
Merge remote-tracking branch 'upstream/master' into plumber_options

# Conflicts:
#	NEWS.md
R/plumber-options.R Outdated Show resolved Hide resolved
R/plumber-options.R Outdated Show resolved Hide resolved
R/plumber-options.R Outdated Show resolved Hide resolved
R/plumber-options.R Outdated Show resolved Hide resolved
Copy link
Contributor

@cpsievert cpsievert left a comment

LGTM pending suggestions

meztez added 3 commits Jun 23, 2020
Merge remote-tracking branch 'upstream/master' into plumber_options

# Conflicts:
#	DESCRIPTION
tests/testthat/test-options.R Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
@schloerke schloerke changed the title Add plumber options doc, setter, getter Add plumber_options() Jun 23, 2020
@schloerke schloerke merged commit a30f5e4 into rstudio:master Jun 23, 2020
15 checks passed
@meztez meztez deleted the plumber_options branch Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants