Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy plumber API #590

Merged
merged 28 commits into from
Jul 22, 2020
Merged

Tidy plumber API #590

merged 28 commits into from
Jul 22, 2020

Commits on Jul 9, 2020

  1. Add intial pr_ functions for "tidy" plumber API; import magrittr pipe… 

    … (%>%)
    @blairj09
    blairj09 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    9afa984 View commit details
    Browse the repository at this point in the history

  2. Initial documentation for pr_ functions

    @blairj09
    blairj09 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    b30fe39 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2020

  1. Apply suggestions from code review 

    Co-authored-by: Barret Schloerke <barret@rstudio.com>
    @blairj09 @schloerke
    blairj09 and schloerke committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    2af50e9 View commit details
    Browse the repository at this point in the history

  2. pr_new() -> pr() 

    Rename pr_set_ functions to be more consistent
    @blairj09
    blairj09 committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    4bcd7bf View commit details
    Browse the repository at this point in the history

  3. Add missing params for pr_register_hooks() and pr_handle()

    @blairj09
    blairj09 committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    f8b67e4 View commit details
    Browse the repository at this point in the history

  4. Add missing pr to all individual handle methods

    @blairj09
    blairj09 committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    dcc9480 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2020

  1. Unit tests for tidy plumber API. Depends on functionality added in rs… 

    …tudio#585 for serializer_content_type
    @blairj09
    blairj09 committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    2a00e24 View commit details
    Browse the repository at this point in the history

  2. Add tidy functions to pkgdown page

    @blairj09
    blairj09 committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    d75543a View commit details
    Browse the repository at this point in the history

  3. pr_default_serializer -> pr_serializer

    @blairj09
    blairj09 committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    d003e05 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2020

  1. Add pr_cookie

    @blairj09
    blairj09 committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    6684970 View commit details
    Browse the repository at this point in the history

  2. Fix pr_404_handler example

    @blairj09
    blairj09 committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    376202a View commit details
    Browse the repository at this point in the history

  3. Minor function argument formatting (spacing)

    @blairj09
    blairj09 committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    3d2fbc4 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2020

  1. Minor function argument formatting (spacing)

    @blairj09
    blairj09 committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    b1d168c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'pr-pipes' of github.com:blairj09/plumber into pr-pipes

    @blairj09
    blairj09 committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    89a81ee View commit details
    Browse the repository at this point in the history

  3. Add unit tests for pr_404_handler and pr_error_handler

    @blairj09
    blairj09 committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    562de07 View commit details
    Browse the repository at this point in the history

  4. Fix breaking tests. The one remaining broken test is dependent on a c… 

    …hange introduced in rstudio#585
    @blairj09
    blairj09 committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    7a62710 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2020

  1. Shorten 3 word pr_ functions: 

    `pr_404_handler` -> `pr_404`
`pr_error_handler` -> `pr_error`
`pr_register_hook` -> `pr_hook`
`pr_register_hooks` -> `pr_hooks`
    @blairj09
    blairj09 committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    c85243a View commit details
    Browse the repository at this point in the history

  2. Add example for pr_error(); 

    Simplify test for `pr_error()`
    @blairj09
    blairj09 committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    812be6c View commit details
    Browse the repository at this point in the history

  3. Update NEWS

    @blairj09
    blairj09 committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    102a034 View commit details
    Browse the repository at this point in the history

  4. Update pkgdown contents list with newly shortened function names

    @blairj09
    blairj09 committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    03555f6 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2020

  1. Implement code review feedback: 

    - Standardize capitalization
- Add checks for pr object
- Minor documentation updates
- POST_BODY -> postBody
    @blairj09
    blairj09 committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    abc7279 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2020

  1. Change function names that modify defaults to be more specific: `pr_s… 

    …et_*()`
    @blairj09
    blairj09 committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    2b33e00 View commit details
    Browse the repository at this point in the history

  2. Split pkgdown reference page into more intuitive sections

    @blairj09
    blairj09 committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    52d0d1c View commit details
    Browse the repository at this point in the history

  3. Standardize capitalization when referencing the Plumber package

    @blairj09
    blairj09 committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    c8166fc View commit details
    Browse the repository at this point in the history

  4. Reorder pkgdown Router reference

    @schloerke
    schloerke committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    bcc3eac View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into pr-pipes

    @schloerke
    schloerke committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    93797d2 View commit details
    Browse the repository at this point in the history

  6. Update test function names

    @schloerke
    schloerke committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    907092f View commit details
    Browse the repository at this point in the history

  7. Call the serializer to set the args (which is none) and return the co… 

    …ntent type serializer
    @schloerke
    schloerke committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    3d6e12a View commit details
    Browse the repository at this point in the history