Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make postBody a delayed assignment. Allows for removal of option. #665

Merged
merged 3 commits into from Sep 3, 2020

Conversation

schloerke
Copy link
Collaborator

@schloerke schloerke commented Aug 31, 2020

Allows for dropping of the

  • Concern: By doing a delayed assign, it could cause the rook input read location to be reset and the whole file will be read.

PR task list:

  • [NA] Update NEWS
  • Add tests
  • Update documentation with devtools::document()

cc @meztez Thought this was a good trick. Add in a delayed assignment for req$postBody. So if no one uses it, it is never calculated. If someone touches it, it will be evaluated.

@schloerke schloerke requested a review from jcheng5 Aug 31, 2020
@schloerke schloerke added this to the v1.0.0 - Next CRAN release milestone Aug 31, 2020
@meztez
Copy link
Collaborator

meztez commented Sep 1, 2020

@schloerke Did not know about delayedAssign, great trick. I would not worry too much about Rook pointer reset. By adding both postbodyraw and postbody, I don't see a need for the original rook stream. I haven't been following closely but I like where you are going with this project and the breaking changes you decided to commit to. Great stuff.

@schloerke schloerke requested a review from cpsievert Sep 1, 2020
schloerke added 2 commits Sep 1, 2020
* master:
  Multipart body followup (#667)
  Copy in properly sized png logo
@schloerke
Copy link
Collaborator Author

schloerke commented Sep 2, 2020

@jcheng5 gentle ping

jcheng5
jcheng5 approved these changes Sep 3, 2020
@jcheng5 jcheng5 merged commit 9e343c2 into master Sep 3, 2020
1 check passed
@jcheng5 jcheng5 deleted the postBody_delay branch Sep 3, 2020
schloerke added a commit that referenced this pull request Sep 3, 2020
* master:
  Pass in `req` and `res` directly to `PlumberStep$exec(req, res)` (#666)
  Make `postBody` a delayed assignment. Allows for removal of option. (#665)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants