Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for spaces in tags (surrounded by quotes) #685

Merged
merged 4 commits into from Dec 29, 2020

Conversation

meztez
Copy link
Collaborator

@meztez meztez commented Oct 2, 2020

Fixes #350

Allow to use spaces in tabs (or other character) as long as they are surrounded by quotes or double quotes.

Fix regex to allow one character description in description for response and tags.

Also reversed order of list elements to match plumber file written order, as appear on screen. This applies to plumber decoration that can be repeated in the same block.

#* @apiTag "a b" Space with double quote
#* @apiTag 'c d' Space with single quote

#* @serializer csv
#* @get /test
#* @tag 'a b'
#* @tag "c d"
function() {
  mtcars
}

In reference to #350

PR task list:

  • Update NEWS
  • Add tests
  • Update documentation with devtools::document()

R/plumb-block.R Outdated Show resolved Hide resolved
R/plumb-globals.R Outdated Show resolved Hide resolved
@schloerke schloerke changed the title allow for spaces in tags (surrounded by quotes) Allow for spaces in tags (surrounded by quotes) Dec 29, 2020
@schloerke schloerke merged commit ec55bd0 into rstudio:master Dec 29, 2020
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Allow spaces in @apiTag
2 participants