Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Plumber$flags #738

Merged
merged 8 commits into from Dec 30, 2020
Merged

Add Plumber$flags #738

merged 8 commits into from Dec 30, 2020

Conversation

schloerke
Copy link
Collaborator

@schloerke schloerke commented Dec 29, 2020

Fixes #592

Now throws an error:

#* @plumber
function(pr) {
  pr() %>%
    pr_get()
}

Now does not print forever:

a <- plumber$new()
b <- plumber$new()

a$mount("B", b)
b$mount("A", a)

print(a)

PR task list:

  • Update NEWS
  • Add tests
  • Update documentation with devtools::document()

@schloerke schloerke changed the title Use Plumber$flags. Fix recursive printing. Fix new router returned in router modifier Add Plumber$flags Dec 30, 2020
@schloerke schloerke merged commit 8bb518d into master Dec 30, 2020
1 check passed
@schloerke schloerke deleted the flags branch December 30, 2020 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant