Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting plumber.docs.callback to NULL will also set legacy plumber.swagger.url #766

Merged
merged 2 commits into from Feb 26, 2021

Conversation

meztez
Copy link
Collaborator

@meztez meztez commented Feb 7, 2021

…cated but supported option plumber.swagger.url.

Currently this does nothing since the router default to plumber.swagger.url when plumber.docs.callback is NULL

library(plumber)
options_plumber(docs.callback = NULL)
pr() %>% pr_run()

This PR will make sure plumber.swagger.url is set to NULL when calling options_plumber(docs.callback = NULL).

We could also stop supporting plumber.swagger.url at some point.

PR task list:

  • Update NEWS
  • Add tests
  • Update documentation with devtools::document()

…cated but supported option `plumber.swagger.url`.
Copy link
Collaborator

@schloerke schloerke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

R/options_plumber.R Show resolved Hide resolved
@schloerke schloerke added this to the v1.1.0 milestone Feb 8, 2021
Co-authored-by: Barret Schloerke <barret@rstudio.com>
@schloerke schloerke changed the title Setting options plumber.docs.callback to NULL will also set depre… Setting plumber.docs.callback to NULL will also set legacy plumber.swagger.url Feb 26, 2021
@schloerke schloerke merged commit 423696f into rstudio:master Feb 26, 2021
schloerke added a commit to blairj09/plumber that referenced this pull request Feb 26, 2021
* master:
  Setting `plumber.docs.callback` to `NULL` will also set legacy `plumber.swagger.url` (rstudio#766)
  Update Hosting vignette to swap RStudio Connect and Digital Ocean (rstudio#774)
schloerke added a commit that referenced this pull request Feb 26, 2021
* master:
  Add `PlumberEndpoint$setPath(path)` (#770)
  Setting `plumber.docs.callback` to `NULL` will also set legacy `plumber.swagger.url` (#766)
  Update Hosting vignette to swap RStudio Connect and Digital Ocean (#774)
  Use `pak` for GHA (#771)
schloerke added a commit that referenced this pull request Mar 1, 2021
* master:
  Un-deprecate `Plumber$run(swaggerCallback=, debug=)` and add `Plumber$run(docs=,quiet=)` (#765)
  Add `PlumberEndpoint$setPath(path)` (#770)
  Setting `plumber.docs.callback` to `NULL` will also set legacy `plumber.swagger.url` (#766)
  Update Hosting vignette to swap RStudio Connect and Digital Ocean (#774)
  Use `pak` for GHA (#771)
  Clarify parameters documentation on when plumber perform type conversion (#756)
  fix brew cask install actions (#761)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants