Fall back to sys env var if R option doesn't exist#934
Merged
schloerke merged 4 commits intorstudio:mainfrom Nov 27, 2023
Merged
Fall back to sys env var if R option doesn't exist#934schloerke merged 4 commits intorstudio:mainfrom
schloerke merged 4 commits intorstudio:mainfrom
Conversation
schloerke
requested changes
Nov 27, 2023
R/options_plumber.R
Outdated
Comment on lines
+105
to
+111
| default | ||
| } else { | ||
| if (res %in% c("TRUE", "FALSE")) { | ||
| return(as.logical(res)) | ||
| } | ||
| res | ||
| } |
Collaborator
There was a problem hiding this comment.
Cosmetic
Suggested change
| default | |
| } else { | |
| if (res %in% c("TRUE", "FALSE")) { | |
| return(as.logical(res)) | |
| } | |
| res | |
| } | |
| return(default) | |
| } | |
| if (res %in% c("TRUE", "FALSE")) { | |
| return(as.logical(res)) | |
| } | |
| res |
Collaborator
Author
|
I'm investigating using package |
schloerke
reviewed
Nov 27, 2023
Collaborator
Yes, it looks promising! https://dgkf.github.io/options/articles/options.html We could probably soft deprecate |
schloerke
reviewed
Nov 27, 2023
schloerke
changed the title
schloerke
added a commit
that referenced
this pull request
Feb 5, 2025
* main: (28 commits) feat: add `excel` serializer/parser (#975) ci: Error on spelling (#981) docs: Improve forward docs a bit (#978) Fix file path tests on windows (#979) bug: Update default debug behaviour to `FALSE` (#976) perf: Avoid disk I/O during parsing (#972) docs: Add note on annotating required parameters (#971) Allows port to be specified as an environment variable (#963) tests: Replace `with_mock()` with `with_mocked_bindings()` (#970) feat(serializer): Add support for ragg and svglite (#964) chore: Fix pkgdown warnings. Use lifecycle inline R badges (#965) v1.2.2 release candidate (#948) bug: Use `{rlang}` instead of `{ellipsis}` (#958) docs: Update URLs (#954) docs: fix table spacing (#951) docs: change link to httr2 in routing and input vignette (#944) Specify interactive mode in doc (#932) Fall back to sys env var if R option doesn't exist (#934) Add support for quoted boundary for multipart request parsing. (#924) chore: Remove parse comment to match implementation (#931) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…umber`.
PR task list:
devtools::document()Setting an option that requires a function using an environment variable with most likely fail. Environment variable are characters.