Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for determining interval for validating objects #48

Merged
merged 4 commits into from Oct 26, 2017

Conversation

@caewok
Copy link
Contributor

@caewok caewok commented Aug 14, 2017

Fix for determining interval for validating objects. Sys.time - lastValidated can result in minutes or other units; use difftime to force the result to be in seconds.

caewok added 4 commits Aug 14, 2017
…alidated can result in minutes or other units; use difftime to force the result to be in seconds.
…aewok/pool into proposed_validation_timing_fix

Conflicts:
	R/pool.R
@bborgesr bborgesr merged commit eadfeb0 into rstudio:master Oct 26, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bborgesr
Copy link
Contributor

@bborgesr bborgesr commented Oct 26, 2017

Thank you so much for this! And I'm sorry it took me so long to get to this!

@bborgesr bborgesr mentioned this pull request Oct 26, 2017
20 of 24 tasks complete
@bborgesr
Copy link
Contributor

@bborgesr bborgesr commented Oct 26, 2017

Could you also sign our Contributor Agreement and send the signed copy to jj@rstudio.com? All contributors to code maintained by RStudio need to sign this document. Once you do it once, however, you never have to do it again! Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.