Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix release checklist (pool 0.1.2) #50

Merged
merged 10 commits into from Nov 2, 2017
Merged

Hotfix release checklist (pool 0.1.2) #50

merged 10 commits into from Nov 2, 2017

Conversation

@bborgesr
Copy link
Contributor

@bborgesr bborgesr commented Oct 13, 2017

Code completion (this PR)

  • Fix all dbplyr wrapper functions (i.e. change ... = ... to ...)
  • Fix positioning of stop("Maximum number of objects in pool has been reached") (currently throwing errors when it shouldn't)
  • Add tests for both fixes above to prevent future regression
  • Add more small executable example in the Rd-files
  • Rebase and use difftime everywhere, per #48 (also, include NEWS item with credit to @caewok)
  • Remove \dontrun in the Rd-files
  • Close all obsolete issues
  • dbplyr:
    • Make sure all relevantdbplyr functions are wrapped in pool (including the deprecated ones, see tidyverse/dbplyr#40 (comment)). Edit: as of today (25/10/2017), there's no .DBIConnection methods declared in either dplyr or dbplyr that are not also wrapped in pool.
    • Request an article about DBI vs dplyr - when to use one vs the other (rstudio/db.rstudio.com#41)

Release checklist (new PR, no code changes there)

  • Create a new branch for the release, like v0.1.2-rc
  • Run devtoools::check() and address any possible problems
  • Bump version to 0.1.2 in NEWS and DESCRIPTION
  • Commit and push to github
  • Download “clean” copy of package and build source package
  • Upload to CRAN
  • When accepted to CRAN:
    • create an annotated tag for the "version bump” commit
    git tag -a v0.1.2 -m "pool 0.1.2 on CRAN"
    git push --tags
    • create and normal-merge a PR for the new release branch

Writing

  • Draft blog post
  • Merge blog post: https://github.com/rstudio/blog/pull/57
  • Update articles in shiny-dev-center
    • Make sure to include all relevant info from original README and original articles
    • Incorporate @slopp's feedback:
      • use case for creating a pool inside the server function (and scoping in general)
      • Rmd documents and how to connect to a database from within one
      • scaling across R projects
bborgesr added 7 commits Oct 13, 2017
… made. Previsouly, this chunk of code was misplaced and it would result in buggy behavior: namely, once the maximum number of objects was reached, no more objects could be checked out (EVEN IF YOU RETURNED ANY/ALL OBJECTS back to the pool)
…s` in DESCRIPTION (because I use it in an example); typo fixes
@bborgesr bborgesr force-pushed the hotfix branch from 93b92a7 to 0b2db12 Nov 1, 2017
@bborgesr bborgesr merged commit 7955437 into master Nov 2, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@bborgesr bborgesr deleted the hotfix branch Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.