Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upHotfix release checklist (pool 0.1.2) #50
Conversation
… made. Previsouly, this chunk of code was misplaced and it would result in buggy behavior: namely, once the maximum number of objects was reached, no more objects could be checked out (EVEN IF YOU RETURNED ANY/ALL OBJECTS back to the pool)
…Size (and are released)
…at the whole purpose of that wrapper
…s` in DESCRIPTION (because I use it in an example); typo fixes
Code completion (this PR)
... = ...to...)stop("Maximum number of objects in pool has been reached")(currently throwing errors when it shouldn't)difftimeeverywhere, per #48 (also, include NEWS item with credit to @caewok)\dontrunin the Rd-filesdbplyrfunctions are wrapped inpool(including the deprecated ones, see tidyverse/dbplyr#40 (comment)). Edit: as of today (25/10/2017), there's no.DBIConnectionmethods declared in eitherdplyrordbplyrthat are not also wrapped inpool.Release checklist (new PR, no code changes there)
v0.1.2-rcdevtoools::check()and address any possible problems0.1.2in NEWS and DESCRIPTIONgit tag -a v0.1.2 -m "pool 0.1.2 on CRAN" git push --tagsWriting