Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upChanged a few DBI methods to dispatch over the first two arguments #57
Conversation
…nd `dbReadTable()` to dispatch over the first two arguments, as per the default definition in DBI (closes #55).
|
Thanks. To test this, can you please run |
|
@krlmlr, I don't get any errors/warnings/messages on I released pool somewhat recently and I didn't have any plans for another release soon. But if this is a breaking change, I can do another release, np. When are you planning on releasing DBI? |
|
Thanks for looking into it! DBI 0.8 is on CRAN, I mentioned that I contacted you regarding the check problems in pool. |
|
Thanks @krlmlr, I also submitted pool 0.1.4 to CRAN yesterday and am now waiting for it to be accepted. |
(as per the default definition in DBI)
@krlmlr, thanks for letting me know about this issue. Are the changes here enough to close #55?
(To be on the safe side, I also went ahead and made the same change to other functions in this file that also have a default implementation in DBI with double dispatch.)